Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

enhance: 二要素認証設定時のセキュリティを強化 #11863

Merged
merged 7 commits into from
Sep 22, 2023
Merged

enhance: 二要素認証設定時のセキュリティを強化 #11863

merged 7 commits into from
Sep 22, 2023

Conversation

syuilo
Copy link
Member

@syuilo syuilo commented Sep 22, 2023

パスワード入力が必要な操作を行う際、二要素認証が有効であれば確認コードの入力も必要にする

What

Why

Additional info (optional)

Checklist

  • Read the contribution guide
  • Test working in a local environment
  • (If needed) Add story of storybook
  • (If needed) Update CHANGELOG.md
  • (If possible) Add tests

@syuilo
enhance: 二要素認証設定時のセキュリティを強化
27f75ec 
パスワード入力が必要な操作を行う際、二要素認証が有効であれば確認コードの入力も必要にする
@github-actions github-actions bot added packages/frontend Client side specific issue/PR packages/backend Server side specific issue/PR labels Sep 22, 2023
@codecov
Copy link

codecov bot commented Sep 22, 2023 •
edited
Loading

Codecov Report

Patch coverage: 72.31% and project coverage change: +0.04% 🎉

Comparison is base (eca8c7a) 78.85% compared to head (d31ac07) 78.90%.

Additional details and impacted files 
@@             Coverage Diff             @@
##           develop   #11863      +/-   ##
===========================================
+ Coverage    78.85%   78.90%   +0.04%     
===========================================
  Files          925      930       +5     
  Lines        97727    98292     +565     
  Branches      7791     7817      +26     
===========================================
+ Hits         77062    77555     +493     
- Misses       20665    20737      +72
Files Changed Coverage Δ
...backend/src/server/api/endpoints/i/update-email.ts 55.46% <17.64%> (-4.19%) ⬇️
...kend/src/server/api/endpoints/i/change-password.ts 57.35% <21.05%> (-9.96%) ⬇️
packages/frontend/src/os.ts 17.61% <23.07%> (+0.11%) ⬆️
...backend/src/server/api/endpoints/i/2fa/register.ts 87.75% <44.44%> (-9.84%) ⬇️
...ckend/src/server/api/endpoints/i/delete-account.ts 80.00% <47.36%> (-12.73%) ⬇️
...backend/src/server/api/endpoints/i/2fa/key-done.ts 92.98% <76.47%> (-3.02%) ⬇️
...end/src/server/api/endpoints/i/2fa/register-key.ts 90.09% <76.47%> (-3.01%) ⬇️
...ckend/src/server/api/endpoints/i/2fa/remove-key.ts 94.39% <76.47%> (-3.46%) ⬇️
...ckend/src/server/api/endpoints/i/2fa/unregister.ts 92.85% <76.47%> (-4.29%) ⬇️
packages/backend/src/core/UserAuthService.ts 88.88% <88.88%> (ø)
... and 5 more

... and 4 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@syuilo syuilo marked this pull request as ready for review September 22, 2023 04:31
@syuilo syuilo merged commit c836157 into develop Sep 22, 2023
16 checks passed
@syuilo syuilo deleted the improve-2fa-security branch September 22, 2023 05:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
packages/backend:test packages/backend Server side specific issue/PR packages/frontend Client side specific issue/PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@syuilo